Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not return err if consistencyLevel is not set to a valid value #36714

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: not return err if consistencyLevel is not set to a valid value #36714

merged 1 commit into from
Oct 16, 2024

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 9, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (3685edb) to head (e4ecccb).
Report is 54 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36714   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files        1299     1299           
  Lines      153063   153069    +6     
=======================================
+ Hits       126170   126189   +19     
+ Misses      21833    21828    -5     
+ Partials     5060     5052    -8
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.06% <100.00%> (+0.67%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <ø> (ø)
internal/distributed/proxy/httpserver/utils.go 87.69% <100.00%> (ø)

... and 20 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 10, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Oct 10, 2024
congqixia
congqixia approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 44d80c1 into milvus-io:master Oct 16, 2024
16 checks passed
@smellthemoon smellthemoon mentioned this pull request Nov 14, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 15, 2024
@smellthemoon @zhuwenxing
enhance: add search params in search request in restful(#36304) (#37673)
b3e6482 
pr: #36304 
pr: #36714 
pr: #36448

---------

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
Co-authored-by: zhuwenxing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smellthemoon @sre-ci-robot @congqixia